feat(hooks): update-available notifier (SessionStart + statusline) + native auto-update docs#209
Merged
Merged
Conversation
…native auto-update docs
fetch_latest_tag only checked the scheme of the INITIAL url; urllib's default opener otherwise follows a 3xx transparently, including an https->http downgrade, without re-applying that check. Install a custom opener whose HTTPRedirectHandler refuses to build a follow-up request when the redirect target isn't https:// (defense-in-depth, ADR-0003 posture) — the refusal surfaces as the same HTTPError urllib raises for an unhandled 3xx, which the existing broad except already degrades to None (fail-silent, unchanged). security-reviewer LOW finding on 786c48d.
Version bump + README badge sync for the new SessionStart/statusline update-notifier; documents its outbound api.github.com surface in security-controls.md (unauthenticated HTTPS GET, HTTPS-only incl. redirect guard, fail-silent, off the hot path — ADR-0003/0004). Claude-Session: https://claude.ai/code/session_01PVTCDji6bEuf9SifQ8tfsa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: a proactive "update available" notifier for codeArbiter (approach Both — notifier + native-auto-update docs). Spec:
.codearbiter/specs/update-available-notifier.md.What
plugin.jsonversion, surface a one-linecodeArbiter: update available X -> Y (run /plugin marketplace update codearbiter)in two surfaces — the SessionStart startup-state block and a compact statusline indicator — both reading the same cache.~/.codearbiter/update-state.json); theapi.github.comfetch runs in a detachedupdate-refresh.pychild, once per day, fail-silent. No synchronous network call is added to the hot path._updatelib.py(version compare, cache, HTTPS-only fetch w/ redirect-downgrade guard, once-daily gate),update-refresh.py(thin detached entry). Stdlib-only (ADR-0004), HTTPS-only (ADR-0003)./plugin marketplace update codearbiteras the official mechanism, notifier as the nudge.security-controls.mddocuments the new outbound surface.Verification
_updatelib,session-start,statusline); every acceptance criterion (AC-1..AC-7) maps to tests;py_compileclean; LF.Bumps ca 2.8.3 → 2.8.4.
https://claude.ai/code/session_01PVTCDji6bEuf9SifQ8tfsa