fix(provenance): confine paths before hashing#349
Closed
SUaDtL wants to merge 2 commits into
Closed
Conversation
Record the SMARTS selection and audited task start before the implementation commit. This preserves the task board's required queued-to-in-progress lifecycle transition.
Provenance records are repository data and must not control git's newline-delimited path protocol or escape the project root. Filter unsafe drift triggers before existence checks, hashing, and drift comparison. CHANGELOG: Reject unsafe provenance paths before startup drift hashing.
Collaborator
Author
|
Superseded by #313, the single hackathon review surface. This PR's recorded head and changes are represented in #313's exact 16-PR / 29-commit / 126-path source manifest. PR #313 passed final exact-head CI at commit 6173b1d and remains open and unmerged. Closing this source PR to avoid parallel review; please continue review and discussion on #313. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git hash-object.caandca-codexhook copies.v2.harden.0001complete through the sanctioned task lifecycle.Why
Provenance records are repository data. They must not control Git's newline-delimited path protocol or resolve outside the project root during SessionStart drift checks.
Verification
python .github/scripts/test_provenancelib.py(109 tests)tech-stack.mdproject suite (15 script suites plus 967 hook tests)python -m py_compilefor all three touched hook copiespython tools/sync-core.py --checkpython .github/scripts/check-plugin-refs.pyTradeoff
Conflict level: §2 L1. The existing Git-based hashing design retains a narrow validation-to-open race under a concurrent local filesystem mutator. The documented boundary assumes a cooperative local host, and descriptor-based hashing would be a separate architecture change.