test: decouple dirty semantics from statusline deadline#356
Closed
SUaDtL wants to merge 1 commit into
Closed
Conversation
The real-repository dirty-state check should prove tracked and untracked semantics without inheriting the statusline's 100 ms response budget. Keep that budget covered by its dedicated mocked test while giving the integration test a contention-tolerant deadline. Closes #352
Collaborator
Author
|
Superseded by #313, the single hackathon review surface. This PR's recorded head and changes are represented in #313's exact 16-PR / 29-commit / 126-path source manifest. PR #313 passed final exact-head CI at commit 6173b1d and remains open and unmerged. Closing this source PR to avoid parallel review; please continue review and discussion on #313. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the real-repository dirty-state test independent of the production statusline latency budget. The semantic check now uses a test-local 5-second deadline, while the dedicated timeout test continues to enforce the production 100 ms fail-soft contract.
This removes runner-contention sensitivity without changing shipped behavior.
Closes #352
Verification
GitDirtyTests: 3 tests passed on Linux..github/scripts/test_*.pysuites passed.Tradeoff
The integration test receives a deliberately larger deadline than production. This follows the project conflict hierarchy at the test boundary: semantic coverage remains deterministic, while the separate budget test retains the actual runtime constraint.
Follow-up
A separate pre-existing clock-boundary failure discovered during verification is tracked in #355 and is not included in this patch.