test: isolate NO_COLOR palette equality from session age#357
Closed
SUaDtL wants to merge 1 commit into
Closed
Conversation
The NO_COLOR comparison should vary only the selected theme. Omitting the irrelevant session id prevents mutable user-ledger age data from changing between its five renderer subprocesses. Closes #355
Collaborator
Author
|
Superseded by #313, the single hackathon review surface. This PR's recorded head and changes are represented in #313's exact 16-PR / 29-commit / 126-path source manifest. PR #313 passed final exact-head CI at commit 6173b1d and remains open and unmerged. Closing this source PR to avoid parallel review; please continue review and discussion on #313. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the
NO_COLORpalette equality test independent of mutable user-ledger state. The theme-only payload now omits its unused session id, so every renderer subprocess produces a call-localage 0sinstead of racing a live age boundary.Shipped statusline behavior is unchanged.
Closes #355
Verification
age 59sversusage 1mas the sole byte difference..github/scripts/test_*.pysuites passed.Tradeoff
The comparison no longer exercises session-dependent ledger output. Under the project conflict hierarchy, that behavior is outside this palette test's obligation and remains covered by dedicated ledger and statusline tests; keeping it here made a theme assertion depend on wall-clock timing.