feat(config): enable PL031 RTC + HCTOSYS on arm64#8
Merged
Conversation
The ArcBox HV backend now exposes a PL031 RTC backed by the host wall clock. RTC_CLASS + RTC_DRV_PL031 bind it via the AMBA bus; RTC_HCTOSYS sets CLOCK_REALTIME from rtc0 at boot, so the guest has correct wall time before the agent's clock-sync ping (TLS validation during early boot). Inert under VZ, which exposes no PL031.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26829c2a22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The virtual PL031 mirrors the host wall clock; an NTP-synced guest must not write adjusted time back into it. Keep the flow one-way (RTC -> system at boot via HCTOSYS).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to arcboxlabs/arcbox#373 (ABX-416).
The ArcBox HV backend now exposes a PL031 RTC backed by the host wall clock. This enables:
CONFIG_RTC_CLASS=y+CONFIG_RTC_DRV_PL031=y— bind the device via the AMBA busCONFIG_RTC_HCTOSYS=y(+_DEVICE="rtc0") — set CLOCK_REALTIME from rtc0 at boot, so the guest has correct wall time before the agent's clock-sync ping (TLS validation during early boot)Inert under VZ, which exposes no PL031. Local build verification against the new arcbox PL031 device in progress.