Skip to content

chore: make eslint happy - #257

Merged
SukkaW merged 16 commits into
masterfrom
fix-react-issue-make-eslint-happy
Jul 22, 2026
Merged

chore: make eslint happy#257
SukkaW merged 16 commits into
masterfrom
fix-react-issue-make-eslint-happy

Conversation

@SukkaW

@SukkaW SukkaW commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary

Update ESLint config and make ESLint happy.

Verification

Checklist

  • pnpm check:ci and pnpm test both pass (plus cargo fmt / clippy / test for Rust changes)
  • I ran the affected surface and observed the change working
  • If a wire message changed: WIRE_PROTOCOL_VERSION is bumped
  • New code and assets are my own work, or their origin and license compatibility are noted above
  • Docs and comments are updated where behavior changed

@SukkaW
SukkaW requested review from AprilNEA and Zerlight July 22, 2026 14:53
@SukkaW
SukkaW force-pushed the fix-react-issue-make-eslint-happy branch from 8939bd1 to 0efc4cd Compare July 22, 2026 14:58
@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the lint setup and applies the resulting cleanup across the workspace. The main changes are:

  • Updated ESLint configuration, suppressions, and dependencies.
  • Renamed imports of foxact's abortable effect hook.
  • Reordered conditions and simplified lint-flagged code.
  • Adjusted tests and package metadata.

Confidence Score: 4/5

The connection provider can retain an obsolete runtime source and should be fixed before merging.

  • Most lint-driven edits preserve existing behavior.
  • A mounted provider no longer responds when connectionSource changes.
  • This can reconnect through the wrong endpoint or runtime source.

packages/client/workbench/src/runtime/provider.tsx

Important Files Changed

Filename Overview
packages/client/workbench/src/runtime/provider.tsx Moves connection-source setup into singleton initialization, dropping synchronization after prop changes.
eslint.config.cjs Updates lint configuration for the renamed abortable-effect hook.
pnpm-workspace.yaml Updates release-age exclusions for the ESLint toolchain.
apps/desktop/src/renderer/src/app.tsx Renames the local binding for foxact's abortable effect hook without changing its implementation.

Reviews (1): Last reviewed commit: "chore: make pnpm happy" | Re-trigger Greptile

Comment thread packages/client/workbench/src/runtime/provider.tsx
@SukkaW
SukkaW merged commit 63b772c into master Jul 22, 2026
11 checks passed
@SukkaW
SukkaW deleted the fix-react-issue-make-eslint-happy branch July 22, 2026 16:49
@linear-code

linear-code Bot commented Jul 22, 2026

Copy link
Copy Markdown

CODE-405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants