refactor(ui): adopt React canary ViewTransition for the session switch - #313
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b63b4c476
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rom react/canary, restore e2e title hooks
# Conflicts: # pnpm-lock.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the imperative View Transition stopgap that #299 shipped (manual
startViewTransition, generation guard, DOM name pairing) with React's official<ViewTransition>component, per the decision to allow the canary channel. Four commits:chore(deps)— catalog react/react-dom →19.3.0-canary-96fcba90-20260728(web/desktop renderers only; mobile pins its own react — the stale catalog comment claiming otherwise is fixed). The canary export is unprefixedViewTransition(stable-track; canary is the channel Next.js ships in production).minimumReleaseAgeExcludeentries added; drop back to latest once 19.3 goes stable.refactor(workbench,ui,desktop)— the declarative rewrite, shaped by two source-verified facts:useSyncExternalStore, which never enters a transition lane —startTransitionaround a store write does nothing. OneuseDeferredValue(selectedId)inuseWorkbenchSessionsbridges the render path into the lane (a documented ViewTransition trigger), and puts the row unmount + header mount in the same deferred commit, which the pairing requires.@linkcode/uigains a typed named re-export via an in-moduledeclare module 'react'augmentation (@types/react tracks stable). The whole stopgap module + its 7 unit tests are deleted; interruption/coalescing is now React's own.fix(assets)— drive-by: the committed pi closure manifest was stale since the ws 7→8 bump (chore(deps): bump ws from 7.5.11 to 8.21.1 #289) nestedws@8.21.0copies under the pi closure;closure.test.tswas already red on master. Regenerated.refactor(webview)— extends the boundary to the web shell's title (the render point feat(workbench,ui): matched-geometry view transition on session switch #299's follow-up commit 8e5b485 covered with the now-removed data attribute).Motion pacing moves to
::view-transition-group(*)on--motion-normal; the app-level reduce-motion preference silences snapshot animations via CSS (the root-attached pseudos are out of reach of the.reduce-motion *reset).Verification
document.startViewTransitioninvocations (the rapid double-fire coalesced by React), zero console errors.biome/eslint(serial — the concurrency OOM is CODE-468) /tscgreen; full vitest suite 2056 passed, including the previously-red closure test.Closes CODE-469