fix(release): stage desktop dependencies per architecture - #356
Merged
Conversation
AprilNEA
marked this pull request as ready for review
July 31, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm deploy --cpu=<arch>Root cause
The desktop release cross-packs x64 and ARM64 artifacts on one runner, while pnpm previously installed only the runner CPU's
@napi-rs/keyring-*optional package. The opposite-architecture artifact therefore lacked its keyring binding, and all threev0.13.0packaging jobs failed artifact verification.Without that verification, affected builds would silently fall back to plaintext daemon credential storage.
Verification
pnpm deploy --cpu=x64staging contains only the Darwin x64 keyring bindingpnpm deploy --cpu=arm64staging contains only the Darwin ARM64 keyring bindingpnpm check:cipnpm test— 2235 passed, 1 skippedLinear: CODE-516