test(workbench): guard new chat session isolation - #401
Merged
Conversation
AprilNEA
marked this pull request as ready for review
August 3, 2026 11:43
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
chatworkspace in the wire-compatible workbench mockRoot cause
The retired View Transition path left
useDeferredValue(selectedId)in the shared workbench session resolver. When a new-chat draft exited, the draft cleared immediately while the deferred selection still named the previous session, so React committed one frame of the previous conversation before rendering the new session.The live-selection fix is already present on
master; this PR adds the missing chat-creation regression boundary. Restoring the deferred selection makes the new assertion fail withNew chat rendered the previous conversation after submission.Impact
Desktop and webview share the guarded workbench session path. A future change can no longer reintroduce the stale-session frame without failing the browser smoke gate.
Verification
pnpm check:cipnpm test— 302 files passed, 3 skipped; 2,435 tests passed, 5 skippedpnpm -F @linkcode/webview e2e:browseruseDeferredValue(selectedId)fails the new-chat isolation assertionTracks CODE-103.