fix: Move DID anchoring provenance to registration#704
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Gatekeeper’s standards-conformant DID Resolution surface to keep /1.0/identifiers/{did} “fixture-friendly” by removing method-specific anchoring provenance from didDocumentMetadata, and instead exposing that provenance via the dereferenceable registration resource at /1.0/identifiers/{did}/registration. It aligns the TypeScript and Rust implementations and updates the Gatekeeper documentation/OpenAPI output accordingly.
Changes:
- Remove
didDocumentMetadata.confirmedanddidDocumentMetadata.timestampfrom conformant/1.0/identifiers/{did}responses (TS + Rust) and adjust tests to lock this in. - Augment
/1.0/identifiers/{did}/registrationto includeconfirmedandtimestampalongside the registration resource (TS + Rust). - Update Gatekeeper docs and generated OpenAPI description to document the new provenance location and rationale.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/gatekeeper/api.test.ts | Updates Jest expectations to ensure conformant resolution omits anchoring provenance and /registration returns it. |
| services/gatekeeper/server/src/identifiers-router.ts | Removes confirmed/timestamp from conformant didDocumentMetadata and builds an augmented registration resource for /registration. |
| rust/services/gatekeeper/tests/http_contract.rs | Updates Rust HTTP contract test to assert provenance is omitted from conformant resolution and exposed via /registration. |
| rust/services/gatekeeper/src/api.rs | Mirrors the TS behavior: strips provenance from conformant metadata and augments /registration output. |
| docs/services/gatekeeper/README.md | Documents the provenance move: conformant resolution stays “boring”; /registration carries confirmation/timestamp details. |
| docs/gatekeeper-api.json | Updates generated OpenAPI descriptions to reflect the provenance move and registration augmentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #702.
/1.0/identifiers/{did}metadatadidDocumentMetadata.confirmedanddidDocumentMetadata.timestampfrom the conformant DID Resolution resultconfirmedandtimestampthrough/1.0/identifiers/{did}/registrationalongside the registration resourceValidation
node --experimental-vm-modules node_modules/.bin/jest tests/gatekeeper/api.test.ts --runInBand --verbosecargo test --manifest-path rust/services/gatekeeper/Cargo.toml --test http_contract -- --nocapturenpm run generate-openapiNote: the Rust test run still reports the existing unused import warning for
queue_outbound_operationinrust/services/gatekeeper/src/lib.rs.