Skip to content

fix: 🐛 Fix web3modal opening on Android.#194

Merged
redDwarf03 merged 19 commits intodevfrom
fix_chains_selection
Oct 29, 2024
Merged

fix: 🐛 Fix web3modal opening on Android.#194
redDwarf03 merged 19 commits intodevfrom
fix_chains_selection

Conversation

@Chralu
Copy link
Copy Markdown
Contributor

@Chralu Chralu commented Oct 24, 2024

Issue origin is not clear. This is a quickfix while there is no better solution.

Comment thread lib/application/app_mobile_format.dart Outdated
@redDwarf03 redDwarf03 force-pushed the fix_chains_selection branch from 3a28d57 to 1c51ffc Compare October 24, 2024 18:26
@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented Oct 29, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13591905 Triggered Generic High Entropy Secret e94a361 lib/domain/repositories/blockchains_list.json View secret
13591906 Triggered Generic High Entropy Secret e94a361 lib/domain/repositories/blockchains_list.json View secret
13591904 Triggered Generic High Entropy Secret e94a361 lib/domain/repositories/blockchains_list.json View secret
10555054 Triggered Alchemy API Key e94a361 lib/domain/repositories/blockchains_list.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@redDwarf03 redDwarf03 marked this pull request as ready for review October 29, 2024 15:08
@redDwarf03 redDwarf03 merged commit d5e567a into dev Oct 29, 2024
@redDwarf03 redDwarf03 deleted the fix_chains_selection branch October 29, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants