Skip to content

fix(ci): post status checks on release PR#131

Merged
rhuanbarreto merged 1 commit into
mainfrom
fix/release-pr-status-checks
Mar 21, 2026
Merged

fix(ci): post status checks on release PR#131
rhuanbarreto merged 1 commit into
mainfrom
fix/release-pr-status-checks

Conversation

@rhuanbarreto

Copy link
Copy Markdown
Contributor

Summary

  • Replace the validate-release-pr reusable workflow call with direct CI triggering + commit status posting
  • Add actions: write and statuses: write permissions to the release workflow
  • After creating/updating the release PR, the workflow now triggers code-pull-request.yml on the release branch via gh workflow run, waits for completion, and posts a "Validate Code" commit status on the release branch HEAD

This fixes the issue where release PRs required manually triggering the validate workflow because:

  1. PRs created with GITHUB_TOKEN don't trigger other workflows (GitHub security)
  2. Reusable workflow_call check names don't match branch protection's expected "Validate Code" check

Ported from the same fix in bun-serve-compress#10.

Test plan

  • Merge and verify the next release PR gets status checks automatically and is mergeable without manual intervention

GitHub Actions GITHUB_TOKEN-created PRs don't trigger other workflows,
and reusable workflow_call check names don't match branch protection
requirements. Replace the validate-release-pr reusable workflow with
direct CI triggering via gh workflow run + commit status posting.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying archgate-cli with  Cloudflare Pages  Cloudflare Pages

Latest commit: e844bdb
Status: ✅  Deploy successful!
Preview URL: https://47215eab.archgate-cli.pages.dev
Branch Preview URL: https://fix-release-pr-status-checks.archgate-cli.pages.dev

View logs

@rhuanbarreto rhuanbarreto merged commit dd2156e into main Mar 21, 2026
8 checks passed
@rhuanbarreto rhuanbarreto deleted the fix/release-pr-status-checks branch March 21, 2026 23:25
@github-actions github-actions Bot mentioned this pull request Mar 21, 2026
rhuanbarreto added a commit that referenced this pull request Apr 29, 2026
The `pull-request` job passed `GITHUB_TOKEN` to simple-release-action.
GitHub mutes downstream events on `GITHUB_TOKEN`-authored pushes, so
`pull_request` synchronize never fired on the release PR — leaving
`Lint, Test & Check` orphaned and the PR blocked on a missing required
status check (recurrence after the workaround in #131).

Generate a GitHub App installation token in the job and pass it to
both `actions/checkout` and `simple-release-action`. App-authored
pushes trigger `pull_request` events naturally, so code-pull-request
and dco workflows run on `refs/pull/N/head` and produce the required
checks. The manual `gh workflow run` / `gh api .../statuses` workaround
is removed; job permissions narrowed to `contents: read`.

Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
rhuanbarreto added a commit that referenced this pull request Apr 29, 2026
…252)

The `pull-request` job passed `GITHUB_TOKEN` to simple-release-action.
GitHub mutes downstream events on `GITHUB_TOKEN`-authored pushes, so
`pull_request` synchronize never fired on the release PR — leaving
`Lint, Test & Check` orphaned and the PR blocked on a missing required
status check (recurrence after the workaround in #131).

Generate a GitHub App installation token in the job and pass it to
both `actions/checkout` and `simple-release-action`. App-authored
pushes trigger `pull_request` events naturally, so code-pull-request
and dco workflows run on `refs/pull/N/head` and produce the required
checks. The manual `gh workflow run` / `gh api .../statuses` workaround
is removed; job permissions narrowed to `contents: read`.

Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
@archgatebot archgatebot Bot mentioned this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant