Skip to content

Initial DataFrames merge#210

Merged
ruebot merged 6 commits intomasterfrom
df
Apr 27, 2018
Merged

Initial DataFrames merge#210
ruebot merged 6 commits intomasterfrom
df

Conversation

@lintool
Copy link
Member

@lintool lintool commented Apr 27, 2018

What does this Pull Request do?

Based on discussion in #190 and the broad support for data frames expressed at the Toronto Datathon, this is the initial merge of the data frames branch.

The functionality is limited, but it doesn't break anything existing, so merging should be fine.

How should this be tested?

I even wrote a new test case!

@codecov
Copy link

codecov bot commented Apr 27, 2018

Codecov Report

Merging #210 into master will decrease coverage by 0.52%.
The diff coverage is 52.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
- Coverage   67.29%   66.76%   -0.53%     
==========================================
  Files          32       33       +1     
  Lines         636      659      +23     
  Branches      124      124              
==========================================
+ Hits          428      440      +12     
- Misses        167      178      +11     
  Partials       41       41
Impacted Files Coverage Δ
...c/main/scala/io/archivesunleashed/df/package.scala 100% <100%> (ø)
src/main/scala/io/archivesunleashed/package.scala 65% <45%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a1ef0...8e16b02. Read the comment docs.

@ruebot ruebot merged commit 3de076c into master Apr 27, 2018
@ruebot ruebot deleted the df branch April 27, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants