Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 68.71% 68.71%
=======================================
Files 39 39
Lines 911 911
Branches 168 168
=======================================
Hits 626 626
Misses 231 231
Partials 54 54Continue to review full report at Codecov.
|
Contributor
|
You are awesome @ruebot! |
ianmilligan1
approved these changes
Jul 26, 2018
Member
ianmilligan1
left a comment
ianmilligan1
left a comment
There was a problem hiding this comment.
LGTM, @ruebot - I'll ping you in Slack to confirm commit message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
We ran into some TravisCI build issues on the issue-203 branch; hitting the 4MB log limit for TravisCI, and a
mvn sitebuild issue with newer versions of dependencies. I've pinned those two dependencies to specific version outlined on Stack Overflow These two commits should solve the issue.How should this be tested?
TravisCI should turn green here, and it has already turned green here on the issue-203 branch.
Additional Notes:
When merging this, let me know before hand. I'd like to make sure the commit message is good.