Skip to content

Remove Tweet utils.#323

Merged
ianmilligan1 merged 2 commits intomasterfrom
issue-322
Jul 15, 2019
Merged

Remove Tweet utils.#323
ianmilligan1 merged 2 commits intomasterfrom
issue-322

Conversation

@ruebot
Copy link
Member

@ruebot ruebot commented Jul 8, 2019

GitHub issue(s):

What does this Pull Request do?

Remove all Tweet analysis functionality.

How should this be tested?

  • TravisCI

Additional Notes:

Need to remove documentation on archivesunleashed.org for next release.

- Resolves #322
- Resolves #206
- Resolves #194
@ruebot ruebot requested review from ianmilligan1 and lintool July 8, 2019 03:40
@codecov-io
Copy link

codecov-io commented Jul 8, 2019

Codecov Report

Merging #323 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   75.95%   74.84%   -1.12%     
==========================================
  Files          41       39       -2     
  Lines        1148     1117      -31     
  Branches      200      197       -3     
==========================================
- Hits          872      836      -36     
- Misses        209      215       +6     
+ Partials       67       66       -1
Impacted Files Coverage Δ
src/main/scala/io/archivesunleashed/package.scala 84.54% <ø> (-0.28%) ⬇️
...archivesunleashed/matchbox/ExtractAtMentions.scala 0% <0%> (-100%) ⬇️
...la/io/archivesunleashed/matchbox/ExtractUrls.scala 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce59c8...5d118cf. Read the comment docs.

@ianmilligan1
Copy link
Member

Will test today or tomorrow, and I can stage the archivesunleashed.org PR as well.

Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds nicely and I think, as noted in #322, this makes sense for the future of the AUT. Approved on my end.

That said, looking forward to hearing @lintool's thoughts as I know he's used these in the past.

@ruebot
Copy link
Member Author

ruebot commented Jul 10, 2019

@lintool can you hit the button?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Twitter/tweet analysis TweetUtilsTest.scala doesn't test Spark, only underlying json4s library More complete Twitter Ingestion

3 participants