Skip to content

Tests#336

Merged
ianmilligan1 merged 6 commits intomasterfrom
tests
Jul 31, 2019
Merged

Tests#336
ianmilligan1 merged 6 commits intomasterfrom
tests

Conversation

@ruebot
Copy link
Member

@ruebot ruebot commented Jul 31, 2019

Checking this branch against CodeCov to see what happens before I consider deleting it.

@codecov-io
Copy link

Codecov Report

Merging #336 into master will increase coverage by 0.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage      75%   75.97%   +0.97%     
==========================================
  Files          39       39              
  Lines        1124     1124              
  Branches      197      197              
==========================================
+ Hits          843      854      +11     
+ Misses        215      205      -10     
+ Partials       66       65       -1
Impacted Files Coverage Δ
...c/main/scala/io/archivesunleashed/df/package.scala 95.23% <ø> (+4.76%) ⬆️
...n/scala/io/archivesunleashed/DataFrameLoader.scala 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c1f1f...9f7e049. Read the comment docs.

@ruebot
Copy link
Member Author

ruebot commented Jul 31, 2019

Cool. Looks like we resolve #265 and I'd mark #263 as closed too since it'll be up around 99% covered.

@ianmilligan1 if you're good with this, I'll write a commit message, and highlight @jrwiebe's work on this in the message.

Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @ruebot. If you provide commit message I can squash+merge.

@ruebot
Copy link
Member Author

ruebot commented Jul 31, 2019

Update test coverage for data frames (#336).

- This commit will fall under @ruebot, but @jrwiebe did the heavy lifting here; see #336 for his commits before they were squashed down.
- Resolves #265
- Resolves #263
- Remove unnecessary $-notation code
- Update Scaladocs

@ianmilligan1 ianmilligan1 merged commit 605afcc into master Jul 31, 2019
@ianmilligan1 ianmilligan1 deleted the tests branch July 31, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants