Add language detection column to webpages.#403
Merged
ianmilligan1 merged 1 commit intomasterfrom Jan 12, 2020
Merged
Conversation
- Addresses #402
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 77.48% 77.53% +0.04%
==========================================
Files 40 40
Lines 1537 1540 +3
Branches 292 292
==========================================
+ Hits 1191 1194 +3
Misses 218 218
Partials 128 128 |
Member
|
Good idea - one of those important filters we have. I’ll try to review later today or first thing tomorrow. |
lintool
approved these changes
Jan 12, 2020
ianmilligan1
approved these changes
Jan 12, 2020
Member
ianmilligan1
left a comment
There was a problem hiding this comment.
Works nicely. For doc purposes, the example script you had was missing an import, but this checked out:
import io.archivesunleashed._
import io.archivesunleashed.df._
RecordLoader.loadArchives("example.arc.gz", sc).webpages().show()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue(s): #402
What does this Pull Request do?
Add language detection column to webpages.
How should this be tested?
Something like:
Should yield:
Additional Notes:
If it comes up, we don't add Remote HTML and Headers on content because we leave that all in there for ExtractHyperlinks, so we can do the domains derivative.