Skip to content

Remaining Matchbox implementations for Scala#415

Merged
ruebot merged 2 commits intoarchivesunleashed:masterfrom
SinghGursimran:final_matchbox
Jan 21, 2020
Merged

Remaining Matchbox implementations for Scala#415
ruebot merged 2 commits intoarchivesunleashed:masterfrom
SinghGursimran:final_matchbox

Conversation

@SinghGursimran
Copy link
Collaborator

@SinghGursimran SinghGursimran commented Jan 21, 2020

Remaining Matchbox implementations for Scala

#223

For Testing

ExtractImageDetailsDF

import io.archivesunleashed._
import io.archivesunleashed.app._

val df = RecordLoader.loadArchives("./src/test/resources/arc/example.arc.gz",sc)
					 .keepImages()
					 .all()

ExtractImageDetailsDF(df).show(10)

@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #415 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage    77.7%   77.96%   +0.25%     
==========================================
  Files          40       41       +1     
  Lines        1552     1570      +18     
  Branches      292      292              
==========================================
+ Hits         1206     1224      +18     
  Misses        218      218              
  Partials      128      128

@SinghGursimran SinghGursimran marked this pull request as ready for review January 21, 2020 04:09
@ruebot ruebot merged commit 71b459c into archivesunleashed:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants