Skip to content

Complete coverage for #66#88

Merged
ruebot merged 1 commit intomasterfrom
Issue-66
Oct 6, 2017
Merged

Complete coverage for #66#88
ruebot merged 1 commit intomasterfrom
Issue-66

Conversation

@greebie
Copy link
Contributor

@greebie greebie commented Oct 6, 2017

The title of this pull-request should be a brief description of what the pull-request fixes/improves/changes. Ideally 50 characters or less.


GitHub issue(s):

If you are responding to an issue, please mention their numbers below.

#66

What does this Pull Request do?

A brief description of what the intended result of the Pull Request (PR) will be, what problem it solves, technical details, and any possible side effects.

Improve coverage for JsonUtils.

How should this be tested?

Codcov and Travis.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Example:

  • Does this change require documentation to be updated?
  • Does this change add any new dependencies?
  • Could this change or impact execution of existing code?

Interested parties

Tag (@ mention) interested parties.

Thanks in advance for your help with the Archives Unleashed Toolkit!

@greebie
Copy link
Contributor Author

greebie commented Oct 6, 2017

I'm hoping this triggers the Map-based .toJson() function and covers 100%

@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #88 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   48.47%   48.59%   +0.12%     
==========================================
  Files          41       41              
  Lines         821      821              
  Branches      147      147              
==========================================
+ Hits          398      399       +1     
+ Misses        382      381       -1     
  Partials       41       41
Impacted Files Coverage Δ
...la/io/archivesunleashed/spark/utils/JsonUtil.scala 100% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b7d2e...70613e0. Read the comment docs.

Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me – go codecov go!

@ruebot ruebot merged commit 41cd498 into master Oct 6, 2017
@ruebot ruebot deleted the Issue-66 branch October 6, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants