Conversation
Contributor
Author
|
I'm hoping this triggers the Map-based .toJson() function and covers 100% |
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 48.47% 48.59% +0.12%
==========================================
Files 41 41
Lines 821 821
Branches 147 147
==========================================
+ Hits 398 399 +1
+ Misses 382 381 -1
Partials 41 41
Continue to review full report at Codecov.
|
ianmilligan1
approved these changes
Oct 6, 2017
Member
ianmilligan1
left a comment
There was a problem hiding this comment.
Looks good to me – go codecov go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title of this pull-request should be a brief description of what the pull-request fixes/improves/changes. Ideally 50 characters or less.
GitHub issue(s):
If you are responding to an issue, please mention their numbers below.
#66
What does this Pull Request do?
A brief description of what the intended result of the Pull Request (PR) will be, what problem it solves, technical details, and any possible side effects.
Improve coverage for JsonUtils.
How should this be tested?
Codcov and Travis.
Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Example:
Interested parties
Tag (@ mention) interested parties.
Thanks in advance for your help with the Archives Unleashed Toolkit!