Conversation
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 49.81% 51.03% +1.21%
==========================================
Files 41 41
Lines 821 821
Branches 147 146 -1
==========================================
+ Hits 409 419 +10
+ Misses 371 360 -11
- Partials 41 42 +1
Continue to review full report at Codecov.
|
Add test for TweetUtils.
Add test for TweetUtils.
ruebot
approved these changes
Oct 7, 2017
Member
|
nice work @greebie! |
Member
|
51.03% codecov 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Test for TweetUtils
GitHub issue(s):
If you are responding to an issue, please mention their numbers below.
#54
What does this Pull Request do?
A brief description of what the intended result of the Pull Request (PR) will be, what problem it solves, technical details, and any possible side effects.
Example:
How should this be tested?
Codecov and Travis should work to cover test.
However, trying out an export from a tweet sample would confirm it works properly.
Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
TweetUtils has a "isVerifiedUser()" function that was merely double-checking for user. I switched this to accept a value for a "verified" (in Twitter's terms) user.
Interested parties
@ruebot
Thanks in advance for your help with the Archives Unleashed Toolkit!