Skip to content

Test ExtractTextFromPDFs. #51#97

Merged
ruebot merged 1 commit intomasterfrom
Issue-51
Oct 15, 2017
Merged

Test ExtractTextFromPDFs. #51#97
ruebot merged 1 commit intomasterfrom
Issue-51

Conversation

@greebie
Copy link
Contributor

@greebie greebie commented Oct 15, 2017

Tests ExtractTextFromPDFs.


GitHub issue(s):

#51

What does this Pull Request do?

Currently it merely tests that the Object creates a PDFParser().

How should this be tested?

Codecov & Travis.

Additional Notes:

Will need to be re-examined as parsing from PDFs is improved.

Example:

  • Does this change require documentation to be updated?
  • Does this change add any new dependencies?
  • Could this change or impact execution of existing code?

Interested parties

Tag (@ mention) interested parties.

Thanks in advance for your help with the Archives Unleashed Toolkit!

@codecov
Copy link

codecov bot commented Oct 15, 2017

Codecov Report

Merging #97 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   57.85%   58.09%   +0.24%     
==========================================
  Files          41       41              
  Lines         821      821              
  Branches      146      146              
==========================================
+ Hits          475      477       +2     
+ Misses        296      294       -2     
  Partials       50       50
Impacted Files Coverage Δ
...unleashed/spark/matchbox/ExtractTextFromPDFs.scala 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 065fb6f...30fd913. Read the comment docs.

@ruebot
Copy link
Member

ruebot commented Oct 15, 2017

@greebie can you update this branch, and then we're good to go?

@greebie
Copy link
Contributor Author

greebie commented Oct 15, 2017

I'm seeing that the branch is up to date(?). But if you merge #95 it will be behind.

@ruebot
Copy link
Member

ruebot commented Oct 15, 2017

You're right. I was looking at something else when I typed that. My bad 🤕

@ruebot ruebot merged commit 3b28ce0 into master Oct 15, 2017
@ruebot ruebot deleted the Issue-51 branch October 15, 2017 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants