Conversation
…re additional testing later on.
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 57.85% 58.09% +0.24%
==========================================
Files 41 41
Lines 821 821
Branches 146 146
==========================================
+ Hits 475 477 +2
+ Misses 296 294 -2
Partials 50 50
Continue to review full report at Codecov.
|
ruebot
approved these changes
Oct 15, 2017
Member
|
@greebie can you update this branch, and then we're good to go? |
Contributor
Author
|
I'm seeing that the branch is up to date(?). But if you merge #95 it will be behind. |
Member
|
You're right. I was looking at something else when I typed that. My bad 🤕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests ExtractTextFromPDFs.
GitHub issue(s):
#51
What does this Pull Request do?
Currently it merely tests that the Object creates a PDFParser().
How should this be tested?
Codecov & Travis.
Additional Notes:
Will need to be re-examined as parsing from PDFs is improved.
Example:
Interested parties
Tag (@ mention) interested parties.
Thanks in advance for your help with the Archives Unleashed Toolkit!