Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

[ruby] Upgrade rubocop to version 0.80.0#106

Merged
ruebot merged 1 commit intomasterfrom
depfu/update/rubocop-0.80.0
Feb 19, 2020
Merged

[ruby] Upgrade rubocop to version 0.80.0#106
ruebot merged 1 commit intomasterfrom
depfu/update/rubocop-0.80.0

Conversation

@depfu
Copy link
Copy Markdown
Contributor

@depfu depfu bot commented Feb 19, 2020

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.79.0 → ~> 0.80.0) · Repo · Changelog

Release Notes

0.80.0

New features

  • #7693: NodePattern: Add ` for descendant search. (@marcandre)
  • #7577: Add AllowGemfileRubyComment configuration on Layout/LeadingCommentSpace. (@cetinajero)
  • #7663: Add new Style/HashTransformKeys and Style/HashTransformValues cops. (@djudd, @eugeneius)
  • #7619: Support autocorrect of legacy cop names for Migration/DepartmentName. (@koic)
  • #7659: Layout/LineLength autocorrect now breaks up long lines with blocks. (@maxh)
  • #7677: Add a cop for Hash#each_key and Hash#each_value. (@jemmaissroff)
  • Add BracesRequiredMethods parameter to Style/BlockDelimiters to require braces for specific methods such as Sorbet's sig. (@maxh)
  • #7686: Add new JUnitFormatter formatter based on rubocop-junit-formatter gem. (@koic)
  • #7715: Add Steepfile to default Include list. (@ybiquitous)

Bug fixes

  • #7644: Fix patterns with named wildcards in unions. (@marcandre)
  • #7639: Fix logical operator edge case in omit_parentheses style of Style/MethodCallWithArgsParentheses. (@gsamokovarov)
  • #7661: Fix to return correct info from multi-line regexp. (@Tietew)
  • #7655: Fix an error when processing a regexp with a line break at the start of capture parenthesis. (@koic)
  • #7647: Fix an undefined method on_numblock error when using Ruby 2.7's numbered parameters. (@hanachin)
  • #7675: Fix a false negative for Layout/SpaceBeforeFirstArg when a vertical argument positions are aligned. (@koic)
  • #7688: Fix a bug in Style/MethodCallWithArgsParentheses that made --auto-gen-config crash. (@buehmann)
  • #7203: Fix an infinite loop error for Style/TernaryParentheses with Style/RedundantParentheses when using EnforcedStyle: require_parentheses_when_complex. (@koic)
  • #7708: Make it possible to use EOL rubocop:disable comments on comment lines. (@jonas054)
  • #7712: Fix an incorrect autocorrect for Style/OrAssignment when using elsif branch. (@koic)

Changes

  • #7636: Remove console from Lint/Debugger to prevent false positives. (@gsamokovarov)
  • #7641: (Breaking) Remove Style/BracesAroundHashParameters cop. (@pocke)
  • Add the method name to highlight area of Layout/EmptyLineBetweenDefs to help provide more context. (@rrosenblum)
  • #7652: Allow pp to allowed names of Naming/MethodParameterName cop in default config. (@masarakki)
  • #7309: Mark Lint/UselessSetterCall an "not safe" and improve documentation. (@jonas054)
  • #7723: Enable Migration/DepartmentName cop by default. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 67 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Feb 19, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2020

Codecov Report

Merging #106 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 058ef65...f0df065. Read the comment docs.

@ruebot ruebot merged commit 2462d73 into master Feb 19, 2020
@depfu depfu bot deleted the depfu/update/rubocop-0.80.0 branch February 19, 2020 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant