Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

[ruby] Upgrade rubocop-rspec to version 1.33.0#71

Merged
ruebot merged 1 commit intomasterfrom
depfu/update/rubocop-rspec-1.33.0
May 24, 2019
Merged

[ruby] Upgrade rubocop-rspec to version 1.33.0#71
ruebot merged 1 commit intomasterfrom
depfu/update/rubocop-rspec-1.33.0

Conversation

@depfu
Copy link
Copy Markdown
Contributor

@depfu depfu bot commented May 14, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (~> 1.32.0 → ~> 1.33.0) · Repo · Changelog

Release Notes

1.33.0

  • Let RSpec/DescribedClass pass Struct instantiation closures. (@schmijos)
  • Fixed RSpec/ContextWording missing contexts with metadata. (@pirj)
  • Fix FactoryBot/AttributeDefinedStatically not working with an explicit receiver. (@composerinteralia)
  • Add RSpec/Dialect enforces custom RSpec dialects. (@gsamokovarov)
  • Fix redundant blank lines in RSpec/MultipleSubjects's autocorrect. (@pirj)
  • Drop support for ruby 2.2. (@bquorning)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 28 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 14, 2019
@ruebot
Copy link
Copy Markdown
Member

ruebot commented May 24, 2019

@​depfu rebase

@depfu depfu bot force-pushed the depfu/update/rubocop-rspec-1.33.0 branch from 83e20f1 to b709b75 Compare May 24, 2019 12:55
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 24, 2019

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #71   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92be496...a7b7cdc. Read the comment docs.

@ruebot
Copy link
Copy Markdown
Member

ruebot commented May 24, 2019

@​depfu rebase

@depfu depfu bot force-pushed the depfu/update/rubocop-rspec-1.33.0 branch from b709b75 to a7b7cdc Compare May 24, 2019 14:11
@ruebot ruebot merged commit 9926313 into master May 24, 2019
@depfu depfu bot deleted the depfu/update/rubocop-rspec-1.33.0 branch May 24, 2019 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants