Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

[ruby] Upgrade rubocop to version 0.74.0#79

Merged
ruebot merged 1 commit intomasterfrom
depfu/update/rubocop-0.74.0
Aug 4, 2019
Merged

[ruby] Upgrade rubocop to version 0.74.0#79
ruebot merged 1 commit intomasterfrom
depfu/update/rubocop-0.74.0

Conversation

@depfu
Copy link
Copy Markdown
Contributor

@depfu depfu bot commented Aug 1, 2019

👉 This PR is queued up to get rebased by Depfu

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.73.0 → ~> 0.74.0) · Repo · Changelog

Release Notes

0.74.0

New features

  • #7219: Support auto-correct for Lint/ErbNewArguments. (@koic)

Bug fixes

  • #7217: Make Style/TrailingMethodEndStatement work on more than the first def. (@buehmann)
  • #7190: Support lower case drive letters on Windows. (@jonas054)
  • Fix the auto-correction of Lint/UnneededSplatExpansion when the splat expansion of Array.new with a block is assigned to a variable. (@rrosenblum)
  • #5628: Fix an error of Layout/SpaceInsideStringInterpolation on interpolations with multiple statements. (@buehmann)
  • #7128: Make Metrics/LineLength aware of shebang. (@koic)
  • #6861: Fix a false positive for Layout/IndentationWidth when using EnforcedStyle: outdent of Layout/AccessModifierIndentation. (@koic)
  • #7235: Fix an error where Style/ConditionalAssignment would swallow a nested if condition. (@buehmann)
  • #7242: Make Style/ConstantVisibility work on non-trivial class and module bodies. (@buehmann)

Changes

  • #5265: Improved Layout/ExtraSpacing cop to handle nested consecutive assignments. (@jfelchner)
  • #7215: Make it clear what's wrong in the message from Style/GuardClause. (@jonas054)
  • #7245: Make cops detect string interpolations in more contexts: inside of backticks, regular expressions, and symbols. (@buehmann)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 40 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Aug 1, 2019
@ruebot
Copy link
Copy Markdown
Member

ruebot commented Aug 4, 2019

@​depfu rebase

@depfu depfu bot force-pushed the depfu/update/rubocop-0.74.0 branch from 970203a to 169a707 Compare August 4, 2019 17:57
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 4, 2019

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #79   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a588cd8...169a707. Read the comment docs.

@ruebot ruebot merged commit dcc59ca into master Aug 4, 2019
@depfu depfu bot deleted the depfu/update/rubocop-0.74.0 branch August 4, 2019 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants