-
Notifications
You must be signed in to change notification settings - Fork 53
add blkid method for uuid #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Did you run genfstab inside |
|
You can use |
|
thanks for the clarifications on the blkid syntax, your example is much more concise. |
|
However, using `mount --make-private` instead of a tmpfs for `/run` as
suggested in https://github.com/archlinux/arch-install-scripts/issues/24
might be a better fix for this problem.
Could you please test that with `/run/udev` present in chroot, `lsblk` can
get the uuids as well?
…
thanks for the clarifications on the blkid syntax, your example is much
more concise.
—
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG6E7V4XHE3GGMKB5P6RABTWBQJVZANCNFSM6AAAAAAQ3JIBMY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I will try to get this bug again. It happen not on all hardware. |
lsblk uses libudev to get device information, but udev isn't always present in the environment where genfstab is run. On the contrary, blkid uses libblkid and gets those informations direct, which shall be preferred. Fixes #24 Closes archlinux#26
udev doesn't work in the chroot which prevents some tools like lsblk to retrieve the UUID of devices. This can be a bit problematic so instead of having /run mounted as a tmpfs, do a bind-mound from the rootfs and include `--make-private`. This is similar to the previous implemention. Fixes https://github.com/archlinux/arch-install-scripts/issues/24 Fixes #26
|
Closing in favour of the |

Hello, using this script, we periodically encountered the problem that "uuid" was not defined on some sections. In the process of studying the problem, it became clear that partition have uuid, but lsblk cannot determine it and gives an empty string. At the same time, BLKID handles uuid detection, I suggest adding BLKID as a fallback way to get uuid to minimize situations when uuid is present but cannot be detected.