common: ensure /run is mounted with --make-private #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udev doesn't work in the chroot which prevents some tools like lsblk to retrieve the UUID of devices. This can be a bit problematic so instead of having /run mounted as a tmpfs, do a bind-mound from the rootfs and include `--make-private`. This is similar to the previous implemention. Fixes https://github.com/archlinux/arch-install-scripts/issues/24 Fixes #26
Foxboron
force-pushed
the
morten/run-make-private
branch
from
9b63fb4 to
0feec4a
Compare
YHNdnzj
approved these changes
Mar 26, 2023
Contributor
|
I'd say ideally if we have to move away from new tmpfs / read-only bind mount, then we should resort to overlayfs. This introduces the regression that the ownership of some directories under It's indeed much less of a problem for the live iso use case but sometimes we do want to Btw I am not sure what's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
udev doesn't work in the chroot which prevents some tools like lsblk to retrieve the UUID of devices. This can be a bit problematic so instead of having /run mounted as a tmpfs, do a bind-mound from the rootfs and include
--make-private.This is similar to the previous implemention.
Fixes https://github.com/archlinux/arch-install-scripts/issues/24