feat: Menu Status Indicator#4663
Open
CooperWang0912 wants to merge 8 commits into
Open
Conversation
This reverts commit 151916a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Motivation
Technical Description
_get_status_prefixfor menu item completion status, with red exclamation marks for required and uncompleted fields, yellow dots for optional and uncompleted fields, and green checks for completed fields.[¹] The checks are achieved using the following logic:_update_item_labelsthat updates the menu render based on_get_status_prefix. The code is as follows:_update_item_labelswhen called, and is triggered with_get_menu_options.[²] The implementation is as follows:Tests and Checks
Notes
[¹] The color scheme and symbols are up for discussion, and changes to these would be fairly straight forward
[²] I am using this primarily to contain the blast radius inside
global_menu, and I would be happy to rework the logic if needed