fix: Allow SSH on first boot - #4676
Open
CooperWang0912 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Technical Details
confirm_ufwthat is called inguided.py, which prompts the user to allow SSH when both ufw and OpenSSH are present.[Note 2] The implementation is as follows:_allow_ufw_ssh_on_first_boot, which creates a service on first boot that enables SSH. The implementation is seen below:FirewallConfigurationand other relevant classes to include the fieldallow_sshTests and Checks
SSH is successfully enabled on first boot.
Notes:
allow_sshfield in theApplication -> Firewalltab, similar to the network configuration warning