Add Cutefish profile - #558
Conversation
|
-1 because it's a niche DE and we already have plenty of DE profiles. Custom Xorg exists for a reason. I also can't find the packages by doing a Google search for Cutefish so that makes it a very strong -1 from me. |
|
It took me a very long time to even find info on this DE. https://cutefishos.com/ |
|
I suppose it'd be okay if we add this file but do not put it in the profiles/desktop.py choice so it can be used for custom scripted installs as a compromise. |
|
It's a very new De but it's already supported by Arch with it's own group. I think archinstall, as the official installer of Arch, should support every DE that is supported by Arch. The profile is just a package list and a command to enable sddm, so it's nothing that requires a lot of work to maintain. Manjaro has also already a Community Edition with Cutefish. |
This isn't really feasible as we have limited resources. Also, things that are more flexible like openbox which requires decent amounts of configuration to get set up in a way that is usable by users are best served by a fully custom installation based on the Xorg profiles. Having lots of options makes regression testing more difficult. |
|
It's also apparently a fork of Cyber with very few changes, from what I'm seeing. https://getcyberos.org/#/ |
|
Add both cyber and cutefish it be good |
|
Does this require SDDM or will lightdm suffice? Historically, the way we have written the profiles is that we do a lightdm installation unless the developers of the DE recommend something else. Specifically, sway doesn't officially support a greeter so we don't use one, KDE and LXQt both only support SDM officially, and GNOME wants GDM. I'm going to test an installation of this DE from the generated ISO now to validate it at least works. |
|
I can validate that this does boot |
| "cutefish", | ||
| "noto-fonts", | ||
| "konsole", | ||
| "sddm" |
There was a problem hiding this comment.
Let's switch sddm to lightdm unless there's a good reason not to.
| # Install the Cutefish packages | ||
| archinstall.storage["installation_session"].add_additional_packages(__packages__) | ||
|
|
||
| archinstall.storage["installation_session"].enable_service("sddm") |
|
yes it works best with sddm |
I agree with @dylanmtaylor on this. Just because Arch Linux supports things, doesn't automatically mean we can. DE's is especially tricky because they have a lot of hidden dependencies like:
All of which has to be tested for possible combinations and on a wire range of hardware. Remove this line for now and I can merge it: archinstall/profiles/desktop.py Line 46 in 3059fa6 installation.install_profile('cutefish')Will still work even after that line is removed. |
Is this documented somewhere? |
@Torxed you can merge this as-is and I can make a commit to remove the line. |
|
Cutefish has now been removed from .desktop, but I think it would be nice to use the profile in the guided installer. Maybe a experimental section? |
|
@JakobDev You can use it like this:
No "experimental" section needed :) |
4 participants
Installs the Cutefish DE