Producing temporary signed URLs from central app for a tenant.

[mdeloughry]

Love the package!

I'm just wondering if anyone has any advice on how to create temporarily signed URLs for a tenant, from inside the central app?

The problem I'm trying to solve is creating a user for a tenant from inside the central app and using https://github.com/spatie/laravel-welcome-notification to send a welcome email.

I'm able to create the user fine, I've also been able to send out the email but the temporary signed URL is always that of the central app, I've even tried overriding the sending/building of the email to be inside initaializeTenancy code block.

eg.

        tenancy()->initializeTenancy($this->tenant);

            $this->showWelcomeFormUrl = URL::temporarySignedRoute(
                'welcome', $this->validUntil, ['user' => $this->user->id]
            );

            return (new MailMessage)
                ->subject('Welcome to my app')
                ->action(Lang::get('Set initial password'), $this->showWelcomeFormUrl);

        tenancy()->endTenancy();

Any help would be greatly appreciated.

[sergeByishimo]

Same issue!

[sergeByishimo]

Some progress!

I intercepted the url before being assigned to the showWelcomeFormUrl property in WelcomeNotification and used spatie's url manipulation package https://github.com/spatie/url to change the host to the first domain of the current initialized tenant.

but still the generated url is not valid!

i overrided initializeNotificationProperties function in my custom welcome notification class

    protected function initializeNotificationProperties(User $user)
    {
        $this->user = $user;

        $this->user->welcome_valid_until = $this->validUntil;
        $this->user->save();

        $domain = tenant()->domains[0];


        $signedUrl = URL::temporarySignedRoute(
            'welcome', $this->validUntil, ['user' => $user->id]
        );

        $url = \Spatie\Url\Url::fromString($signedUrl);

        $this->showWelcomeFormUrl = $url->withHost($domain);
    }

[stancl]

Hi,

So the issue is that the URL::temporarySignedRoute() method is generating URLs for the central domain?

https://github.com/spatie/laravel-welcome-notification/blob/ccf8b6a9158b90c52386ae53d760d72320838398/src/WelcomeNotification.php#L68-L70

Hmm. Does running something like this

$tenant = ...;

$tenant->run(function () {
    dd(\URL::temporarySignedRoute(...));
});

in the central app also result in the domain in the URL being wrong?

You could replace the domains manually but ideally the domain for the URL generator would be correct when the call is wrapped in $tenant->run() or tenancy()->initialize().

If you can reproduce this by calling temporarySignedRoute() yourself in a $tenant->run() block, I'll make the package somehow switch the domain when initializing tenancy.

[sergeByishimo]

Yes

$tenant = ...;

$tenant->run(function () {
    dd(\URL::temporarySignedRoute(...));
});

result with the central app domain!

it seems to not care whether its wrapped in the $tenant->run() or tenancy()->initialize().
you can do a simple test yourself!

[stancl]

Alright, I'll try to fix this soon.

[sergeByishimo]

thanks that would help a lot!

[stancl]

Actually, this is not a bug because the package has no way of knowing which domain it should use when you're calling things from the central domain.

But luckily, Laravel's UrlGenerator comes with a formatHostUsing() method that accepts a callback letting you return the host used in the generated URLs.

For specific calls, you can do this:

$tenant->run(function (Tenant $tenant) {
    URL::formatHostUsing(function () use ($tenant) {
        return 'https://' . $tenant->domains[0];
    });

    // ...
});

Or if you want this to happen automatically (and always for domains[0]), you can use the bootstrapping hook:

tenancy()->hook('bootstrapping', function (TenantManager $tm, Tenant $tenant) {
    URL::formatHostUsing(function () use ($tenant) {
        return 'https://' . $tenant->domains[0];
    });
});

[stancl]

I would close this but I think it might be useful to mention this solution in the documentation.