test: removal of purging keyvault key#281
Merged
stijnmoreels merged 2 commits intoarcus-azure:masterfrom Mar 17, 2022
Merged
Conversation
|
✔️ Deploy Preview for arcus-scripting ready! 🔨 Explore the source changes: 14a3a4c 🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-scripting/deploys/6231d729e0a110000b928f4a 😎 Browse the preview: https://deploy-preview-281--arcus-scripting.netlify.app |
stijnmoreels
approved these changes
Mar 17, 2022
Member
stijnmoreels
left a comment
stijnmoreels
left a comment
There was a problem hiding this comment.
Aha aha, great! Wasn't I think fully aware we did this. Nice catch! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are now using unique keynames we don't need to purge the keyvault keys anymore for the private keys in the private key tests. This was causing tests to sometimes fail as the purging happened to fast after initial deletion.