feat(vba): extract Enum and Const declarations - #14
Merged
Conversation
Dysflow exports the full module text, so a constants module carries its Enum...End Enum blocks and Const lines verbatim. The extractor parsed neither, leaving the project's domain dictionary (status enums, config constants) invisible in the graph. Add a sweepEnumsAndConsts pass to VbaExtractor: - enum node + one enum_member per member, contains edge enum->member - constant node per declared name (multi-name lines included) - contains edge module/class->enum and ->constant - visibility folds like procedures (Private->private, else public) - enum_member qualifiedName is enum-scoped (EnumName.Member) REQ-CODE-10 narrowed to Option-directives-only files; a file with Enum/Const but no procedures now emits a module/class node. Updates the real-fixtures assertion for constantes.bas accordingly and adds REQ-CODE-12/13 to the spec.
This was referenced Jun 30, 2026
ardelperal
added a commit
that referenced
this pull request
Jul 3, 2026
- vba-graph-connectivity-fixes (PR #14, 9b1787a; affected issues #12, #13) - vba-api-declarations (PR #31, 9b614b7; issue #15) - 2026-06-30-vba-event-tracer (PR #36, 393b14d) - 2026-06-30-vba-sql-impact (PR #38, ba25ef4) The artifact folders had been left in openspec/changes/ after their PRs landed on main; an openspec list now reports them as still-active, which masks the true state of the SDD pipeline. Move to archive/ alongside the other finished changes and update [Unreleased] to record the hygiene. Pure docs/text move, zero product-code impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 1 of 2 closing high-value VBA-for-Access extraction gaps found by reviewing CodeGraph against the Dysflow export pipeline.
What
Dysflow exports the full module text into .bas/.cls, so a real constants module (constantes.bas) carries Public Enum ... End Enum blocks and Public Const lines verbatim. The extractor parsed neither — status enums and config constants were invisible in the graph.
Changes
Tests (strict TDD)
New extraction-vba-enums-consts.test.ts (14 cases), red then green. No regressions (the only failures, frameworks-integration JVM + mcp-roots EPERM, are pre-existing Windows-flaky, confirmed on baseline). tsc clean.