Small bugfix and huge speedup #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
eigen-value
requested changes
Jun 6, 2025
Collaborator
eigen-value
left a comment
eigen-value
left a comment
There was a problem hiding this comment.
I agree on the general PR, but some changes need to be reverted because the library is still under test in a threading scenario
| while (!decoder.get_response(msg_id, result, error)){ | ||
| decoder.process(); | ||
| delay(1); | ||
| if (!decoder.process()) { |
Collaborator
There was a problem hiding this comment.
This behaviour is still under test in a multithreading context. The delay here is actually a placeholder for a thread yield.
If the client doesn't yield every time its waiting response is not ready, then it can slow down another thread (eg server).
It's better to leave everything as it was and make a decision when we discuss about if/how threading is involved
per1234
added
type: imperfection
Collaborator
|
I'm merging this as is and do the little revert later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Giga (zephyr) and UNO R4