Skip to content

Small bugfix and huge speedup #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

Small bugfix and huge speedup #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6b89fa
bugfix: don't overwrite random memory on flush_buffer()
facchinm Jun 5, 2025
351ca5e
speedup decoding considerably
facchinm Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions src/SerialTransport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,8 @@ class SerialTransport: public ITransport {
}

size_t read(uint8_t* buffer, size_t size) override {

size_t r_size = 0;

while (_stream->available()){
if (r_size == size){
return r_size;
}
buffer[r_size] = _stream->read();
r_size++;
// TODO the following delay is essential for GIGA to work. Is it worth making giga-specific?
delay(1);
}

return r_size;

_stream->setTimeout(0);
return _stream->readBytes(buffer, size);
}

size_t read_byte(uint8_t& r) override {
Expand Down
5 changes: 3 additions & 2 deletions src/client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@ class RPCClient {
RpcError error;
// blocking call
while (!decoder.get_response(msg_id, result, error)){
decoder.process();
delay(1);
if (!decoder.process()) {
Copy link
Collaborator

@eigen-value eigen-value Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behaviour is still under test in a multithreading context. The delay here is actually a placeholder for a thread yield.
If the client doesn't yield every time its waiting response is not ready, then it can slow down another thread (eg server).
It's better to leave everything as it was and make a decision when we discuss about if/how threading is involved

delay(1);
}
}

lastError.code = error.code;
Expand Down
13 changes: 9 additions & 4 deletions src/decoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,12 @@ class RpcDecoder {

}

void process(){
if (advance()) parse_packet();
bool process(){
if (advance()) {
parse_packet();
return true;
}
return false;
}

// Fill the raw buffer to its capacity
Expand All @@ -188,8 +192,9 @@ class RpcDecoder {
delay(1);
}
}
return true;
}
return true;
return false;
}

void parse_packet(){
Expand Down Expand Up @@ -263,7 +268,7 @@ class RpcDecoder {
inline bool buffer_full() const { return _bytes_stored == BufferSize; }
inline bool buffer_empty() const { return _bytes_stored == 0;}
inline void flush_buffer() {
uint8_t* discard_buf;
uint8_t discard_buf[CHUNK_SIZE];
while (_transport.read(discard_buf, CHUNK_SIZE) > 0);
_bytes_stored = 0;
}
Expand Down