Add fix for codeaurora.org phaseout #963
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ docs-content deploy preview ready
|
jcarolinares
requested changes
Apr 5, 2023
Contributor
jcarolinares
left a comment
jcarolinares
left a comment
There was a problem hiding this comment.
Waiting important feedback from @martab1994 and @MaxPayne86 regarding a potential error in the mirrors of the NXP config file
Comment on lines
+153
to
+158
| MIRRORS += " \ | ||
| git://source.codeaurora.org/external/imx/ git://github.com/nxp-imx/ \n \ | ||
| https://source.codeaurora.org/external/imx/ https://github.com/nxp-imx/ \n \ | ||
| http://source.codeaurora.org/external/imx/ http://github.com/nxp-imx/ \n \ | ||
| gitsm://source.codeaurora.org/external/imx/ gitsm://github.com/nxp-imx/ \n \ | ||
| ``` |
Contributor
There was a problem hiding this comment.
@martab1994 and @MaxPayne86 I just wanted to confirm if those "\n" should be there? I think we should remove them?
Contributor
There was a problem hiding this comment.
@jcarolinares I didn't noticed them! So they are needed according to openembedded-core/meta/classes/mirrors.bbclass
jhansson-ard
added
arduino
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Contribution Guidelines