Removing Recheck and Filter Condition's columns from Bitmap Heap Scan output list when using ORCA.#284
Merged
Stolb27 merged 4 commits into6.19.0_arenadata31from Jan 20, 2022
Merged
Conversation
InnerLife0
force-pushed
the
ADBDEV-2204-3
branch
from
41763d3 to
6c72208
Compare
InnerLife0
changed the title
Collaborator
|
@maksm90, please take a look at this one. |
Stolb27
reviewed
Dec 7, 2021
src/backend/gporca/libgpopt/src/translate/CTranslatorExprToDXL.cpp
Outdated
Show resolved
Hide resolved
|
Could anyone assume why the |
maksm90
reviewed
Dec 13, 2021
InnerLife0
force-pushed
the
ADBDEV-2204-3
branch
from
269f27b to
09d918e
Compare
… output list when using ORCA. The changes introduced in PR #12176 revealed a problem with excessive Bitmap Heap Scan's targetlist which includes Recheck and Filter Condition's columns (introduced in old 97edf9b). Memory tuple binding generated based on targetlist with different count of attrs may point to different offsets and so, to some garbage or out of range memory area. See issue #12796 for more. Additional regression test shows how to reproduce a bug before fix. A couple of tests was modified, because there is no need of projection in them started from this patch.
InnerLife0
force-pushed
the
ADBDEV-2204-3
branch
from
09d918e to
354024c
Compare
InnerLife0
changed the title
maksm90
reviewed
Dec 20, 2021
src/backend/gporca/data/dxl/minidump/Gist-AOCOTable-NonLossy-BitmapIndexPlan.mdp
Show resolved
Hide resolved
maksm90
previously approved these changes
Dec 21, 2021
RekGRpth
pushed a commit
that referenced
this pull request
Mar 2, 2026
* Retarget resgroup tests to v23 CI tag * Set environment variable for force Docker client API version usage DOCKER_API_VERSION=1.41 Task: CI-5305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes introduced in PR #12176 revealed a problem with excessive Bitmap Heap Scan's targetlist which includes Recheck and Filter Condition's columns (introduced in old 97edf9b).
Memory tuple binding generated based on targetlist with different count of attrs may point to different offsets and so, to some garbage or out of range memory area. See issue #12796 for more.
Additional regression test shows how to reproduce a bug before fix. A couple of tests was modified, because there is no need of projection in them started from this patch.