Conversation
… output list when using ORCA. (#284) The changes introduced in PR #12176 revealed a problem with excessive Bitmap Heap Scan's targetlist which includes Recheck and Filter Condition's columns (introduced in old 97edf9b). Memory tuple binding generated based on targetlist with different count of attrs may point to different offsets and so, to some garbage or out of range memory area. See issue #12796 for more. Additional regression test shows how to reproduce a bug before fix. A couple of tests was modified, because there is no need of projection in them started from this patch. Natively raise exception in case of targetlist mismatch.
GUC value rollback was added by commit 09e4d0a But it was found that GUC values of PGC_STRING type should be quoted or parsing will fail otherwise as, for example, for gp_default_storage_options GUC: "ERROR","42601","syntax error at or near ""=""",,,,,,"SET gp_default_storage_options TO appendonly=false,blocksize=32768,compresstype=none,checksum=true,orientation=row",45,,"scan.l",1062, As failed SET command leads to transaction abort that leads to backend exit that triggers RemoveTempRelationsCallback to remove temp relations, the new tests verify that after GUC PGC_STRING value rollback no temp relation is removed. The values with GUC_LIST_INPUT set in flags should not be quoted as it will destroy list otherwise. For example as for search_path: SET search_path TO '"$user",public' should remain SET search_path TO "$user",public
RekGRpth
pushed a commit
that referenced
this pull request
Mar 4, 2026
* Retarget Behave tests CI to v24 tag * Mount sqldump/dump.sql to cdw service in docker compose * Enable gpexpand behave test Task: ADBDEV-9130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Own added value.
Fixes: