NGSOK-1876 Fix spark-daemon.sh not forwarding SIGTERM in foreground mode#52
Merged
Merged
Conversation
Use exec when running the daemon command in the SPARK_NO_DAEMONIZE (foreground) branch of execute_command(), so the JVM replaces the wrapper shell instead of running as its child. Without this, the wrapper shell remains PID 1 in containers, the kernel suppresses its default SIGTERM disposition since it is PID 1 with no trap, and the JVM's shutdown hooks never run until SIGKILL after the grace period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use exec when running the daemon command in the SPARK_NO_DAEMONIZE (foreground) branch of execute_command(), so the JVM replaces the wrapper shell instead of running as its child. Without this, the wrapper shell remains PID 1 in containers, the kernel suppresses its default SIGTERM disposition since it is PID 1 with no trap, and the JVM's shutdown hooks never run until SIGKILL after the grace period.