Add PCLO and PCHO signal and remote the old PCO signal - #93
Merged
Conversation
Signed-off-by: Arghya Biswas <arghyabiswas05@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the microcode signal map to split the old PCO virtual output into two distinct signals (PCHO and PCLO) and updates instruction tables and documentation to match.
Changes:
- Replace the
PCOvirtual output signal withPCHO(upper PC bits) andPCLO(lower PC bits) in the microcode config and instruction tables - Update hardware/design docs to reference the new signals and anchors
- Bump project/component version numbers
Reviewed changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Microcode/MicroCodeConfig.yaml | Updates virtual output signal codes to use PCHO/PCLO instead of PCO. |
| Microcode/Instructions/InsADD.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsAND.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsCALL.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsCMI.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsCMIS.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsCMP.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsCMPS.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsDEC.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsHLT.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsINC.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsJMC.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsJME.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsJMG.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsJML.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsJMP.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsJMZ.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsJNZ.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsLDI.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsLDM.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsLDR.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsMOV.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsNOP.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsNOT.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsOR.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsOUT.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsOUTS.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsPOP.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsPSHV.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsPUSH.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsRST.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsRTN.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsSAV.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsSHL.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsSHR.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsSTR.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsSUB.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Microcode/Instructions/InsXOR.py | Updates instruction signal table rows to reflect PCHO/PCLO. |
| Docs/SignalInfo.md | Documents the new PCHO and PCLO signals. |
| Docs/HwDesign.md | Updates pin/signal reference table links from PCO to PCHO/PCLO. |
| Config.yaml | Bumps overall and component version numbers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+241
to
244
| PCHO : 0b1100 | ||
| SqR : 0b1101 | ||
| RESRV1: 0b1110 | ||
| PCLO : 0b1110 | ||
| RESRV2: 0b1111 # Reserved if no Pin need to be enabled |
Comment on lines
+84
to
+86
| * <a id="signal-pcho"></a>`PCHO`: The PCHO signal load the value from the higher 3 bit of PC register to the bus. | ||
|
|
||
| * <a id="signal-pclo"></a>`PCLO`: The PCLO signal load the value from the lower 8 bit of PC register to the bus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.