Skip to content

fix(ui): Hide "Sync" button in resource details header for Un-managed resources.#22357

Closed
surajyadav1108 wants to merge 2 commits intoargoproj:masterfrom
surajyadav1108:resource-details-sync-button
Closed

fix(ui): Hide "Sync" button in resource details header for Un-managed resources.#22357
surajyadav1108 wants to merge 2 commits intoargoproj:masterfrom
surajyadav1108:resource-details-sync-button

Conversation

@surajyadav1108
Copy link
Member

@surajyadav1108 surajyadav1108 commented Mar 15, 2025

Part of #21578

With this now resource details will show sync button for managed resources only, similar to actionitems for a resource

hide-sync-for-unmanaged.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
@surajyadav1108 surajyadav1108 requested a review from a team as a code owner March 15, 2025 07:49
@bunnyshell
Copy link

bunnyshell bot commented Mar 15, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@surajyadav1108 surajyadav1108 added the component:ui User interfaces bugs and enhancements label Mar 24, 2025
@surajyadav1108
Copy link
Member Author

Closing this just realized there is already a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:ui User interfaces bugs and enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant