chore: add unit tests to test the Run function of argocd CLI commands#24780
Draft
onasser1 wants to merge 2 commits intoargoproj:masterfrom
Draft
chore: add unit tests to test the Run function of argocd CLI commands#24780onasser1 wants to merge 2 commits intoargoproj:masterfrom
Run function of argocd CLI commands#24780onasser1 wants to merge 2 commits intoargoproj:masterfrom
Conversation
❌ Preview Environment undeployed from BunnyshellAvailable commands (reply to this comment):
|
Contributor
Author
|
/assign |
Contributor
Author
|
Could you review this when you're free, please? @nitishfy |
Signed-off-by: Omar Nasser <omarnasserjr@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24780 +/- ##
==========================================
- Coverage 60.73% 60.68% -0.05%
==========================================
Files 404 404
Lines 66168 66168
==========================================
- Hits 40186 40157 -29
- Misses 22722 22750 +28
- Partials 3260 3261 +1 ☔ View full report in Codecov by Sentry. |
nitishfy
requested changes
Sep 30, 2025
Member
nitishfy
left a comment
There was a problem hiding this comment.
I don't think it's the correct way to test the Run function. Infact, i'm not sure how is this testing the Run function either. Is this PR ready for review? If no, i'd consider putting it as draft.
Run function of argocd CLI commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Related #24684