Unable to create AnalysisRuns with provider type Kayenta

[kcboschert]

When trying to create an AnalysisRun from an AnalysisTemplate with kayenta defined as the provider, we received the following error:

analysis spec invalid: metrics[0]: no provider specified

The AnalysisRun and AnalysisTemplate CRDs are both configured to allow for this value:

argo-rollouts/manifests/crds/analysis-template-crd.yaml

Line 2574 in fbe33e8

kayenta:

argo-rollouts/manifests/crds/analysis-run-crd.yaml

Line 2580 in fbe33e8

kayenta:

But it looks like the validation in the Analysis factory isn't expecting Kayenta as an option:

argo-rollouts/utils/analysis/factory.go

Lines 140 to 155 in fbe33e8

	numProviders := 0
	if metric.Provider.Prometheus != nil {
	numProviders++
	}
	if metric.Provider.Job != nil {
	numProviders++
	}
	if metric.Provider.Web != nil {
	numProviders++
	}
	if metric.Provider.Wavefront != nil {
	numProviders++
	}
	if numProviders == 0 {
	return fmt.Errorf("no provider specified")
	}

[dthomson25]

Yikes, that's a bad one. I'll make a PR to fix that.