feat(cli): add create-project command and drop commander env bindings#343
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Add `argos create-project <name> --account <slug>`, backed by the `POST /projects` API endpoint. Supports `--token`, `--json`, and the `ARGOS_ACCOUNT` / `ARGOS_TOKEN` environment variables. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Remove all commander `.env()` bindings from the CLI. Environment variables are now resolved in the config/target layer instead of by commander: - `ARGOS_PROJECT` for build-scoped commands is resolved in `target.ts` (alongside the existing `ARGOS_TOKEN` fallback). - `ARGOS_ACCOUNT` for `create-project` is resolved in the command. - Load `threshold` in `readConfig` so `ARGOS_THRESHOLD` (and `--threshold`) are honored again — it was in the schema but missing from the load block. Env vars for the upload/finalize/skip/deploy paths were already handled by core `readConfig`. Resolves ARG-456 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gregberge
force-pushed
the
cli/create-project-drop-env-bindings
branch
from
99d7105 to
6ce6e01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
argos create-project <name> --account <slug>command, backed by thePOST /projectsAPI endpoint (mirrors feat(backend): add API endpoint to create a project (ARG-451) argos#2352). Supports--token,--json, andARGOS_ACCOUNT/ARGOS_TOKENenv vars..env()bindings from the CLI. Environment variables are now resolved in the config/target layer instead of by commander:ARGOS_TOKEN,ARGOS_PROJECT,ARGOS_BUILD_NAME,ARGOS_MODE,ARGOS_PARALLEL_*,ARGOS_REFERENCE_*— already handled by corereadConfig.ARGOS_PROJECTfor build-scoped commands (review/comment/build) — now resolved intarget.ts(alongside the existingARGOS_TOKENfallback).ARGOS_ACCOUNTforcreate-project— resolved in the command.thresholdwas in the config schema but missing fromreadConfig's load block, soARGOS_THRESHOLD(and even--threshold) were being dropped. It's now loaded, with CLI option taking priority over env.Resolves ARG-456
Test plan
packages/cli:check-types,lint, andtest(46 passed) all green.packages/core:check-typesgreen;config.test.ts(15 passed) including 2 new tests coveringARGOS_THRESHOLDand option-over-env priority..env(bindings remain inpackages/cli/src.🤖 Generated with Claude Code