Merged
Conversation
cburgdorf
force-pushed
the
christoph/ci/mac-win
branch
from
abe0180 to
29a7617
Compare
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 70.86% 70.86%
=======================================
Files 29 29
Lines 2073 2073
=======================================
Hits 1469 1469
Misses 604 604 Continue to review full report at Codecov.
|
cburgdorf
force-pushed
the
christoph/ci/mac-win
branch
10 times, most recently
from
8aa71b5 to
2f66692
Compare
Collaborator
Author
|
Ok, finally hitting the point where a cache entry was restored
As explained here cache entries don't work cross PRs. A cache entry created in one PR won't be accessible from another. However, a cache entry created from master will be accessible to all PRs. |
cburgdorf
force-pushed
the
christoph/ci/mac-win
branch
3 times, most recently
from
27803e6 to
674c8df
Compare
cburgdorf
force-pushed
the
christoph/ci/mac-win
branch
from
674c8df to
e5c9221
Compare
Collaborator
Author
|
@g-r-a-n-t I was fighting with Windows support for some hours but eventually gave up and udpated #62 For now, merging this PR ensures we at least target Linux and Mac. |
g-r-a-n-t
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
We only test against Linux
How was it fixed?
Added support for Mac
To-Do