Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 88.02% 87.90% -0.13%
==========================================
Files 36 36
Lines 2279 2281 +2
==========================================
- Hits 2006 2005 -1
- Misses 273 276 +3
Continue to review full report at Codecov.
|
Closed
35a7c61 to
0955a27
Compare
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 88.02% 87.94% -0.08%
==========================================
Files 36 36
Lines 2279 2281 +2
==========================================
Hits 2006 2006
- Misses 273 275 +2
Continue to review full report at Codecov.
|
0955a27 to
e9caee2
Compare
e9caee2 to
d285eaa
Compare
d285eaa to
635916e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
We need to have support for
revertexpressions.How was it fixed?
test_functioninto two functions in order to re-use it for revert assertionreverttorevert(0,0)in YUL (Ignoring revert reasons Implement revert reasons #75 for now)revertin the specTo-Do