Codegen: Fix ICE on parenthesized custom error construction in require statement - #16876
Merged
blishko merged 1 commit intoJul 24, 2026
Merged
Conversation
…e statement In a require statement, a second argument can be provided, which can be a string or a custom error. Parser allows the argument to be included in parentheses. Typechecker is also fine with such an expression. However, code generation, for both legacy and IR pipelines, previously assumed the custom error construction is not parenthesized. Specifically, the code previously assumed this AST node is `FunctionCall`. But when parenthesized, this node would be a `TupleExpression`, resulting in a `std::bad_cast` exception. The proposed fix strips away the unary tuple layers from the expression before casting, using the helper `resolveOuterUnaryTuples` from `ASTUtils`.
blishko
force-pushed
the
fix-crash-on-parenthesized-custom-error-in-require
branch
from
July 20, 2026 14:45
57327f3 to
a3a3ff3
Compare
blishko
commented
Jul 20, 2026
| @@ -0,0 +1,11 @@ | |||
| // This could be a syntax test, but we want to check compilation with --via-ir as well. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a require statement, a second argument can be provided, which can be a string or a custom error.
Parser allows the argument to be included in parentheses. Typechecker is also fine with such an expression. However, code generation, for both legacy and IR pipelines, previously assumed the custom error construction is not parenthesized.
Specifically, the code previously assumed this AST node is
FunctionCall. But when parenthesized, this node would be aTupleExpression, resulting in astd::bad_castexception.The proposed fix strips away the unary tuple layers from the expression before casting, using the helper
resolveOuterUnaryTuplesfromASTUtils.Fixes #16683.