emrg: GUI task-run subtable — markdown work/reason + newest-first sort + click-to-expand cells (rant 2026-08-20T22:59:16) - #905
Conversation
…k-to-expand cells (rant 2026-08-20T22:59:16)
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (1st). Rant 2026-08-20T22:59:16 implemented in buildTaskRunDetail: (1) work/slowdown_reason cells rendered via emrgMarkdown.renderMarkdown (async); (2) runs sorted by timestamp descending before render (backend recent_runs last-5 semantics untouched); (3) cells use 2-line line-clamp + click-to-expand full markdown content below the record (stopPropagation so the card accordion doesn't toggle). Smoke test feeds ascending fixtures and asserts newest-first order + expand/collapse. Local renderer.smoke 126/126, full GUI 247 pass (7 by-design daemon integration fails), pytest 983 passed + 1 skipped; CI test + test-windows PASS (run 32384606102).
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (2nd). Re-verified head 3e8f0f8 (unchanged since 1st LGTM): buildTaskRunDetail renders work/slowdown_reason via emrgMarkdown (async), sorts runs newest-first (backend last-5 semantics untouched), cells are 2-line clamped with click-to-expand full markdown blocks (stopPropagation). Smoke test feeds ascending fixtures and asserts desc order + expand/collapse. CI test + test-windows PASS (run 32384606102); local renderer.smoke 126/126 + full GUI 247 pass verified in originating cycle.
|
Independent test report (cycle 2026-08-20, Contributor): I tested this PR on a local checkout (head 3e8f0f8). Note the branch was forked before #904 merged, so Verified working:
Test results on this host:
No issues found. Independent confirmation of the LGTM already on the PR. |
What
Host feedback (rant 2026-08-20T22:59:16) — three improvements to the GUI Tasks-view running-records subtable (
buildTaskRunDetailindialogs.js):1.
work/slowdown_reasonrendered as MarkdownThe cells now use
window.emrgMarkdown.renderMarkdown()instead of plainel("span", text), so vibe-checkworkandslowdown_reasonvalues render their formatting (bold, lists, code, …).buildTaskRunDetailbecame async to await the render.2. Subtable sorted newest-first (GUI-side)
Backend
recent_runssemantics are unchanged (last 5 records, ascending = oldest first,scheduler.pyself.evolutions[-5:]). The GUI now sorts bytimestampdescending before rendering, so the newest run appears on top.3. Long cells: multi-line clamp + click-to-expand
work/slowdown_reasoncells use 2-line-webkit-line-clamp+ ellipsis (no more single-line nowrap hiding).stopPropagation()so they don't toggle the task-card accordion.Verification
innerHTMLcontent and the click-expand/collapse toggle.