ci: Fix !bencher-thresholds-reset PR comment#466
Merged
Conversation
Match the workflow filename to the `!bencher-thresholds-reset` command it handles. The old `bench-thresholds-reset.yml` name didn't match the command, which made it easy to typo as `!benchmark-thresholds-reset` — a miss that silently reset nothing at merge. Keep the `bencher` spelling (not `benchmark`) so it can't collide with bench-pr.yml's `!benchmark` trigger. Add an `ack` job: when a maintainer comments the command on a still-open PR, reply confirming the baseline reset is queued for the merge commit, or warn if the workload is unknown/missing — immediate feedback instead of silence until merge. Bot-guarded so its own reply can't re-trigger it. The reset still runs only on merge (pull_request.merged == true), never on a non-merged close.
The ack job (comment time) is now the single place that parses and validates the !bencher-thresholds-reset command; it records each valid workload as a baseline-reset:<workload> label. The merge-time reset job reads those labels straight from the event payload instead of re-scanning and re-parsing PR comments, so the interpret logic lives in exactly one place. The label is also human-visible and can be removed to cancel a queued reset. Adds issues: write so ack can create/apply the label.
…label Rename the moved git tag baseline-reset-<workload> -> bencher-thresholds-reset-<workload> (and its reader in bencher-track/action.yml) so the command, workflow, label, and tag all share one name. Make `all` a first-class label: ack applies bencher-thresholds-reset:all verbatim, and the merge job is the single place that expands an `all` label into every workload.
arthurpaulino
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies the reset command to
!bencher-thresholds-reseteverywhere, and adds a comment reply that confirms whether or not the action parsed the command correctly.Also switches from only parsing on PR close to adding a PR label that queues the threshold reset, which can also be added/removed manually by maintainers. This way if someone queues the reset accidentally it can be rolled back before merge.