Keep LinqraftMapping capture support and remove AsLeftJoin / QueryExtensions work#304
Conversation
Co-authored-by: arika0093 <4524647+arika0093@users.noreply.github.com>
Co-authored-by: arika0093 <4524647+arika0093@users.noreply.github.com>
Co-authored-by: arika0093 <4524647+arika0093@users.noreply.github.com>
Co-authored-by: arika0093 <4524647+arika0093@users.noreply.github.com>
Co-authored-by: arika0093 <4524647+arika0093@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 060404a8a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| builder.AppendLine( | ||
| $"{request.MethodAccessibilityKeyword} static {receiverType}<{request.ResultTypeName}> {request.MethodName}(this {receiverType}<{request.SourceTypeName}> source)" | ||
| $"{request.MethodAccessibilityKeyword} static {receiverType}<{request.ResultTypeName}> {request.MethodName}(this {receiverType}<{request.SourceTypeName}> source{string.Concat(request.Captures.Select(capture => $", {capture.TypeName} {capture.LocalName}"))})" |
There was a problem hiding this comment.
Use capture member names in generated mapping signatures
The generated mapping method now declares capture parameters using capture.LocalName, which is the internal synthetic name (for example __linqraft_capture_0_offset) rather than the user-facing capture name (offset, suffix). This makes named-argument calls fail (ProjectTo...(..., offset: 10, suffix: "x") no longer compiles) and exposes unstable implementation-detail names in the public API surface, which is especially problematic for mappings generated as public methods.
Useful? React with 👍 / 👎.
|
@copilot apply codex's review.
|
Co-authored-by: arika0093 <4524647+arika0093@users.noreply.github.com>
Fixed in d75e27d. The generated mapping signature now uses the stable capture property names ( |
This PR narrows the scope back to
LinqraftMappingcapture variables only. AllAsLeftJoin/Linqraft.QueryExtensionswork has been removed so it can proceed separately, while mapping-generated methods continue to support captured values.Scope reset
AsLeftJoin-related generator changesLinqraft.QueryExtensionspackage and its registration infrastructureplan.mdcontent that had shifted to the separate query-extension designMapping capture support retained
LinqraftMappingGenerateLinqraftMappingDeclare<T>Documentation
docs/library/mapping-methods.mdwith capture-parameter guidance and examples for both:Example of the retained mapping capture flow:
This keeps the PR focused on the mapping capture feature and leaves the query-extension / left-join work for a separate follow-up.
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.