refactor(yamllint): rename config to .yamllint.yml and match published standard - #86
Merged
Merged
Conversation
…d standard The repository publishes the yamllint standard in rst/ but its own config diverged from it: the file was named .yamllint instead of .yamllint.yml, capped line-length at 160 instead of 500, and omitted "on" from truthy.allowed-values. The published text stays untouched. Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
There was a problem hiding this comment.
No issues found.
Verified this is a clean, well-scoped refactor:
- Rename
.yamllint→.yamllint.yml(an auto-detected yamllint config name, so discovery keeps working). line-length.max160→500 andtruthy.allowed-values+onboth match the published standard inrst/guide/development/cicd.rstandrst/guide/getting-started/environment.rst. Both are relaxations, so no previously-passing file can newly fail.- References in
lefthook.ymlandAGENTS.mdupdated; no stale.yamllintfilename references remain anywhere in the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.yamllintto.yamllint.ymlviagit mv, matching the name this repository publishes inrst/guide/best-practices/standards.rst,rst/guide/development/cicd.rstandrst/guide/getting-started/environment.rstline-length.max160 to 500, and"on"added totruthy.allowed-values. The published text is unchanged; the config follows itlefthook.yml,AGENTS.md) so the pre-commit hook stays resolvable at every point in historyAll 16 rules, all 10 ignores (including the repo-specific
build/,temp-rst/,rst/collections/) andline-length.level: warningare kept.Test plan
yamllint -c .yamllint .before the change: exit 0, twodocument-startwarnings (docker-compose.yml,.dde/config.yml)yamllint -c .yamllint.yml .after the change: exit 0, the same two warnings — behaviour-neutral. Both warnings pre-date this changerg '\.yamllint(?!\.yml)' --pcre2returns nothinggit diff --cached --stat -Mshows.yamllint => .yamllint.ymlas a rename, not delete plus addlefthook.ymlresolves the new path